[Bug 797203] shmsrc: race condition when stopping

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797203

--- Comment #4 from Aleix Conchillo Flaqué <aconchillo at gmail.com> ---
(In reply to Olivier Crête from comment #2)

Thanks for the comments. Started to do some GStreamer again lately, I'm rusty!
:-)

> Review of attachment 373760 [details] [review]:
> 
> ::: sys/shm/gstshmsrc.c
> @@ +278,2 @@
>      gst_shm_pipe_dec (self->pipe);
> +    GST_OBJECT_LOCK (self);
> 
> Are you sure this unlock+relock is not racy?
> 

Yes, it looks racy but I think it should be fine since self->pipe is only NULL
when the element is initialized and only set NULL in this function. So, I don't
think there's a way to shoot yourself in the foot. I think... ?

Fixed all the other comments.

I was talking to Josep Torra about this. He might have something else to say,
let's wait until he jumps in.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.