[Bug 796092] meson: use new python module

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796092

--- Comment #6 from Jan Tojnar <jtojnar at gmail.com> ---
Review of attachment 371989:
 --> (https://bugzilla.gnome.org/review?bug=796092&attachment=371989)

The meson_version attribute should be bumped:

    WARNING: Project specifies a minimum meson_version '>= 0.36.0' but uses
features which were added in newer versions:
     * 0.37.0: {'shared_module'}
     * 0.46.0: {'Python Module'}

::: meson.build
@@ +23,2 @@
 pygobject_dep = dependency('pygobject-3.0', version : '>= 3.8')
 python_dep = dependency('python3')

This can be removed?

@@ +38,3 @@
 pygi_override_dir = get_option('pygi-overrides-dir')
 if pygi_override_dir == ''
+    cres = run_command(python, '-c','''

Why not save this to a separate file? It would support syntax highlighting
other dev tools.

@@ +47,3 @@
+        print(path)
+        exit(0)
+exit(1)

This does not have the “Otherwise follow python's way of install site packages
inside the provided prefix” branch from the original detector script, making it
fail in cases where `gi.overrides.__path__` does not start with `prefix` (e.g.
on NixOS). But since the  value can be fixed using meson option, it is probably
alright.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.