[Bug 787922] splitmuxsink: add a "split-now" action signal

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787922

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373772|none                        |needs-work
             status|                            |

--- Comment #32 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373772:
 --> (https://bugzilla.gnome.org/review?bug=787922&attachment=373772)

::: gst/multifile/gstsplitmuxsink.c
@@ +429,3 @@
+   * Note that this is prone to race conditions, where said running time is
+   * reached and surpassed before we had a chance to split. The file will
+   * still split, but in order to make sure that the split doesn't happen too

Maybe mention *when* it will be split then (on the next opportunity, ASAP).
Otherwise one might think that it will split on the next fragment only maybe :)

@@ +1869,3 @@
+  if (splitmux->reference_ctx->in_running_time >= time_to_split) {
+    GST_OBJECT_LOCK (splitmux);
+    splitmux->time_to_split = GST_CLOCK_TIME_NONE;

This is racy: Between taking the local copy of this value above, and resetting
it here the signal could've been called again. You would then overwrite a *new*
value here where splitting would happen.

Maybe just compare against the local version and only reset if it a) changed
and b) the changed value is after the current split position (i.e. in the
future, we still have the opportunity to split there)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.