[Bug 759867] gl: Add support to compose VideoOverlayCompositionMeta before the display sink

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Sep 27 09:57:27 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=759867

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373780|none                        |reviewed
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373780:
 --> (https://bugzilla.gnome.org/review?bug=759867&attachment=373780)

Looks good to me

::: ext/gl/gstgloverlaycompositorelement.c
@@ +66,3 @@
+    GST_PAD_ALWAYS,
+    GST_STATIC_CAPS (GST_VIDEO_CAPS_MAKE_WITH_FEATURES
+        (GST_CAPS_FEATURE_MEMORY_GL_MEMORY,

If downstream supports the overlay composition meta, should we maybe not render
it here and passthrough?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list