[Bug 787922] splitmuxsink: add a "split-now" action signal

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787922

--- Comment #36 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Thanks, please review again.

(In reply to Sebastian Dröge (slomo) from comment #32)
> Review of attachment 373772 [details] [review]:
> 
> ::: gst/multifile/gstsplitmuxsink.c
> @@ +1869,3 @@
> +  if (splitmux->reference_ctx->in_running_time >= time_to_split) {
> +    GST_OBJECT_LOCK (splitmux);
> +    splitmux->time_to_split = GST_CLOCK_TIME_NONE;
> 
> This is racy: Between taking the local copy of this value above, and
> resetting it here the signal could've been called again. You would then
> overwrite a *new* value here where splitting would happen.
> 
> Maybe just compare against the local version and only reset if it a) changed
> and b) the changed value is after the current split position (i.e. in the
> future, we still have the opportunity to split there)

Using a GstQueueArray now to queue up possible split times. This shouldn't be
an issue.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.