[Bug 787922] splitmuxsink: add a "split-now" action signal

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787922

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373794|none                        |needs-work
             status|                            |

--- Comment #40 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373794:
 --> (https://bugzilla.gnome.org/review?bug=787922&attachment=373794)

::: gst/multifile/gstsplitmuxsink.c
@@ +1885,3 @@
+    while (ptr_to_time) {
+      time_to_split = *ptr_to_time;
+      if (splitmux->reference_ctx->in_running_time >= time_to_split) {

Above is >, here is >=. Is that correct?

@@ +1886,3 @@
+      time_to_split = *ptr_to_time;
+      if (splitmux->reference_ctx->in_running_time >= time_to_split) {
+        gst_queue_array_pop_head_struct (splitmux->times_to_split);

You need to do

> ptr_to_time = gst_queue_array_peek_head_struct (splitmux->times_to_split);

here again, to peek at the next one and then check if that is also in the past

@@ +3117,3 @@
+    GST_INFO_OBJECT (splitmux, "Requesting next keyframe at %"
GST_TIME_FORMAT,
+        GST_TIME_ARGS (split_time));
+    if (!gst_pad_push_event (splitmux->reference_ctx->sinkpad, ev)) {

You want to release the lock before sending the event

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.