[Bug 787922] splitmuxsink: add a "split-now" action signal

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787922

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373803|none                        |needs-work
             status|                            |

--- Comment #42 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373803:
 --> (https://bugzilla.gnome.org/review?bug=787922&attachment=373803)

::: gst/multifile/gstsplitmuxsink.c
@@ +1890,3 @@
+        break;
+      }
+      ptr_to_time = gst_queue_array_peek_head_struct
(splitmux->times_to_split);

Simpler:

while {
  if (y < x)
    break;

  pop();
  ptr_to_time = peek();
}

@@ +3116,3 @@
+    GstEvent *ev =
+        gst_video_event_new_upstream_force_key_unit (split_time, TRUE, 0);
+    GST_SPLITMUX_UNLOCK (splitmux);

You can simply unlock before the if

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.