[0.10] gst-plugins-ugly: x264enc: remove useless and semantically ( though not practically) wrong code

Tim Müller tpm at kemper.freedesktop.org
Wed Jan 18 04:25:00 PST 2012


Module: gst-plugins-ugly
Branch: 0.10
Commit: 25c227ab2300e4280a196a0c1296990f50418deb
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-ugly/commit/?id=25c227ab2300e4280a196a0c1296990f50418deb

Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Fri Jan 13 13:46:50 2012 +0000

x264enc: remove useless and semantically (though not practically) wrong code

The object will be freed, so it's pointless to set the pointers
to NULL anyway.

---

 ext/x264/gstx264enc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ext/x264/gstx264enc.c b/ext/x264/gstx264enc.c
index 2be3dd3..ea3cf0b 100644
--- a/ext/x264/gstx264enc.c
+++ b/ext/x264/gstx264enc.c
@@ -962,7 +962,7 @@ gst_x264_enc_finalize (GObject * object)
 
 #define FREE_STRING(ptr) \
   if (ptr) \
-    ptr = (GString *)g_string_free (ptr, TRUE);
+    g_string_free (ptr, TRUE);
 
   FREE_STRING (encoder->tunings);
   FREE_STRING (encoder->option_string);



More information about the gstreamer-commits mailing list