gst-plugins-base: playbin2: do not try to deactivate an inactive group

Vincent Penquerc'h vincent at kemper.freedesktop.org
Mon Jan 23 03:57:09 PST 2012


Module: gst-plugins-base
Branch: master
Commit: c433ef9b701f48bae2d0268323d4f69972b91c7f
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=c433ef9b701f48bae2d0268323d4f69972b91c7f

Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Wed Jan 18 14:58:08 2012 +0000

playbin2: do not try to deactivate an inactive group

A group may have failed to activate due to an error (for instance,
having set the URI to a non existent location in about-to-finish).

https://bugzilla.gnome.org/show_bug.cgi?id=666395

---

 gst/playback/gstplaybin2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c
index f8ccb51..e01ff6c 100644
--- a/gst/playback/gstplaybin2.c
+++ b/gst/playback/gstplaybin2.c
@@ -3846,7 +3846,7 @@ save_current_group (GstPlayBin * playbin)
   /* see if there is a current group */
   GST_PLAY_BIN_LOCK (playbin);
   curr_group = playbin->curr_group;
-  if (curr_group && curr_group->valid) {
+  if (curr_group && curr_group->valid && curr_group->active) {
     /* unlink our pads with the sink */
     deactivate_group (playbin, curr_group);
   }



More information about the gstreamer-commits mailing list