[gst-devel] Re: [gst-cvs] CVS: gstreamer/gst gstbuffer.c,1.36.2.7,1.36.2.8 gstbuffer.h,1.26.4.3,1.26.4.4

[Wim Taymans]

On Sun, 2001-09-23 at 08:03, Joshua Pritikin wrote:
> Update of /cvsroot/gstreamer/gstreamer/gst
> In directory usw-pr-cvs1:/tmp/cvs-serv31657/gst
> 
> Modified Files:
>       Tag: BRANCH-EVENTS1
> 	gstbuffer.c gstbuffer.h 
> Log Message:
> 1 Add GST_BUFFER_WHERE support to bytestream.

I don't like this patch at all. 

It screws up automatic doc generation, adds bloat, looks ugly and should
be done in a more general way IMO, ie. not only on buffer creation but
as a general trace feature (possibly with -finstrument-functions). I've
added a print_stack_trace feature in my local copy using the
-finstrument-functions option that does exactly what this patch does and
more (and cleaner).

Another option (and an idea I have been toying with for some time) is to
create a GstElementBox element that would fork() and let an arbitrary
element (even bin) run in its own address space. Communication between
the processes would be done using shm or pipes. This would make
monitoring the element much more flexible and accurate without ugly
hacks.

so, let's not get into this and back out the patch before someone starts
adding similar code to GstProps/Caps/Events/whatmore.

Wim

<snip ugly hack>