[gst-devel] trivial gst-player patch
Joshua N Pritikin
vishnu at pobox.com
Wed Aug 7 03:37:02 CEST 2002
i'm am trying to use the gstplay library as the engine of my custom
video player.
Here is a trivial patch to quiet some gcc warnings. Apparently i
have more warnings enabled by default.
--
Victory to the Divine Mother!! after all,
http://sahajayoga.org http://why-compete.org
-------------- next part --------------
--- /home/joshua/gst/gst-player//libs/gst/play/play.c Tue Jul 30 21:15:38 2002
+++ play.c Wed Aug 7 16:00:54 2002
@@ -65,8 +65,6 @@
static void callback_video_have_xid (GstElement *element, gint xid, GstPlay *play);
static void callback_video_have_size (GstElement *element, gint width, gint height, GstPlay *play);
-static void callback_audio_bin_pre_iterate (GstBin *bin, GstPlay *play);
-static void callback_audio_bin_post_iterate (GstBin *bin, GstPlay *play);
static void callback_bin_pre_iterate (GstBin *bin, GMutex *mutex);
static void callback_bin_post_iterate (GstBin *bin, GMutex *mutex);
@@ -95,6 +93,7 @@
(GClassInitFunc) gst_play_class_init,
NULL, NULL, sizeof (GstPlay),
0, (GInstanceInitFunc) gst_play_init,
+ NULL
};
play_type = g_type_register_static (G_TYPE_OBJECT, "GstPlay", &play_info, 0);
@@ -448,7 +447,7 @@
{
gint64 value;
GstFormat format = GST_FORMAT_TIME;
- gboolean query_worked;
+ gboolean query_worked = FALSE;
g_print("trying to get length\n");
if (play->audio_sink_element != NULL){
@@ -638,8 +637,8 @@
GList *pads = NULL;
gboolean has_src;
- g_return_if_fail (GST_IS_PLAY (play));
- g_return_if_fail (GST_IS_ELEMENT (element));
+ g_return_val_if_fail (GST_IS_PLAY (play), NULL);
+ g_return_val_if_fail (GST_IS_ELEMENT (element), NULL);
if (!GST_IS_BIN(element)){
/* since its not a bin, we'll presume this
@@ -673,8 +672,8 @@
gboolean
gst_play_set_video_sink (GstPlay *play, GstElement *video_sink)
{
- g_return_if_fail (GST_IS_PLAY (play));
- g_return_if_fail (GST_IS_ELEMENT (video_sink));
+ g_return_val_if_fail (GST_IS_PLAY (play), FALSE);
+ g_return_val_if_fail (GST_IS_ELEMENT (video_sink), FALSE);
if (gst_play_get_state (play) != GST_STATE_READY){
gst_play_set_state (play, GST_STATE_READY);
@@ -691,8 +690,8 @@
gboolean
gst_play_set_audio_sink (GstPlay *play, GstElement *audio_sink)
{
- g_return_if_fail (GST_IS_PLAY (play));
- g_return_if_fail (GST_IS_ELEMENT (audio_sink));
+ g_return_val_if_fail (GST_IS_PLAY (play), FALSE);
+ g_return_val_if_fail (GST_IS_ELEMENT (audio_sink), FALSE);
if (gst_play_get_state (play) != GST_STATE_READY){
gst_play_set_state (play, GST_STATE_READY);
More information about the gstreamer-devel
mailing list