[gst-devel] element's STATE_CHANGE signal
Andy Wingo
wingo at pobox.com
Fri Jan 18 08:20:04 CET 2002
IIRC signals + SMP + multithreading + gtk1.2 = badness.
dunno about glib2.
also i hear SMP + threads is broken right now, not sure on the current
status.
i think the threading stuff needs fixage, dunno about this patch. but if
threading on smp already doesn't work, then this patch shouldn't have
any problems. i'll wait for a more knowledgable answer before committing
though --
wingo.
On Fri, 18 Jan 2002, Benjamin Otte wrote:
> Is there a reason not to emit that signal?
>
> If there isn't, here's a patch:
>
> Index: gst/gstelement.c
> ===================================================================
> RCS file: /cvsroot/gstreamer/gstreamer/gst/gstelement.c,v
> retrieving revision 1.103
> diff -u -r1.103 gstelement.c
> +++ gst/gstelement.c 2002/01/18 16:07:04
> @@ -1035,7 +1035,8 @@
>
> GST_STATE (element) = GST_STATE_PENDING (element);
> GST_STATE_PENDING (element) = GST_STATE_VOID_PENDING;
> -
> + g_signal_emit (G_OBJECT (element), gst_element_signals[STATE_CHANGE],
> 0, old_state, GST_STATE (element));
> +
> parent = GST_ELEMENT_PARENT (element);
>
> if (parent && GST_IS_BIN (parent)) {
>
>
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
More information about the gstreamer-devel
mailing list