[gst-devel] Re: [gst-cvs] thomasvs gstreamer: gstreamer/gst/

[Thomas Vander Stichele]

> > +++ gstformat.h	31 May 2002 08:51:32 -0000	1.2
> > @@ -40,7 +40,7 @@
> >    GST_FORMAT_SAMPLES 	= 3,
> >  
> >    /* video related */
> > -  GST_FORMAT_FRAMES 	= 4,
> > +  GST_FORMAT_FRAMES 	= 4,  /* can also be used for compressed audio */
> >    GST_FORMAT_FIELDS 	= 5,
> >  } GstFormat;
> 
> frames in the l-a-d audio world means one sample from each channel. this
> is much more useful than 'samples', i suggest we remove 'SAMPLES' and
> replace it with something like FRAMES. it's really a shame that 'frames'
> is so over-abused...
> 
> actually, i take that back. an audio 'frame' is more analogous to a
> video 'frame' than a 'frame' in the sense of mp3, etc. so i vote to
> revert this change, and use some other concept of 'frame' for mp3s, and
> to make frames a GstFormat that is common both to audio and video. any
> objections?

Well, I agree with you in a way.  Only it's a shame that frame is the 
actual term used in mpeg audio compression.  maybe we could call it 
GST_FORMAT_FRAMES_COMPRESSED or something.
But I agree with dropping GST_FORMAT_SAMPLES.

Note that I didn't actually /change/ anything ;)

Thomas

The Dave/Dina Project : future TV today ! - http://davedina.apestaart.org/
<-*-                      -*->
And every time she sneezes
I think it's love and oh lord
I'm not ready for this sort of thing
<-*- thomas at apestaart.org -*->
URGent, the best radio on the Internet - 24/7 ! - http://urgent.rug.ac.be/