[gst-devel] [release patch] iradio mode fixup in gnomevfssrc

[Colin Walters]

Hello,

I'd like to get the attached patch into the 0.6.0 release.  It is a very
tiny patch for gnomevfssrc which makes it so gnomevfssrc doesn't make a
size request in iradio mode.  The info method tries to do a PROPFIND
request, which most internet radio servers barf on.

Does anyone object or see any problems with the patch?

-------------- next part --------------
--- gstgnomevfssrc.c.~1.25.~	2002-12-30 12:53:13.000000000 -0500
+++ gstgnomevfssrc.c	2003-01-25 15:39:37.000000000 -0500
@@ -3,7 +3,7 @@
  *                    2000 Wim Taymans <wtay at chello.be>
  *                    2001 Bastien Nocera <hadess at hadess.net>
  *                    2002 Kristian Rietveld <kris at gtk.org>
- *                    2002 Colin Walters <walters at gnu.org>
+ *                    2002,2003 Colin Walters <walters at gnu.org>
  *
  * gnomevfssrc.c:
  *
@@ -1047,7 +1047,10 @@
 			return FALSE;
 		}
 
-		/* find the file length */
+		/* find the file length (but skip it in iradio mode,
+		 * since it will require a separate request, and we
+		 * know the length is undefined anyways) */
+		if (!src->iradio_mode)
 		{
 			GnomeVFSResult size_result;
 			GnomeVFSFileInfo *info;
@@ -1061,10 +1064,12 @@
 			else
 				src->size = info->size;
 
-		        GST_DEBUG(0, "size %lld", src->size);
-
 			gnome_vfs_file_info_unref(info);
 		}
+		else
+			src->size = 0;
+
+		GST_DEBUG(0, "size %lld", src->size);
 
 		audiocast_do_notifications(src);