[gst-devel] type finding

Colin Walters walters at debian.org
Thu Jan 30 16:45:02 CET 2003

On Thu, 2003-01-30 at 17:58, David I. Lehn wrote:

> [As a side note, this mp3 type code has buffer range errors.  It could,
> in theory, segfault if the input buffer is < 4 bytes.  Or more likely,
> do type detecting on invalue buffer data!  

This is fixed now.

> I think for the immediate fix the mp3 code should scan the entire buffer
> it gets.  Which is slower and could fail if buffer is short and has no
> start code.  But it's better than nothing.

Your API changes look good to me.  I would say though that we shouldn't
worry a lot about the performance penalty; after all, in the common case
GStreamer will have filename extensions to work with.  

Also, it might be good for apps to have a way to give hints to the
autoplugger about the expected media type (I didn't see a way to do this
currently).  So that way the autoplugger could try those types first,
with both low and high effort, and only later fall back to other types.

More information about the gstreamer-devel mailing list