[gst-devel] Re: [gst-cvs] omegahacker gstreamer: gstreamer/gst/

[David I. Lehn]

* Erik Walthinsen <omegahacker at users.sourceforge.net> [20030131 01:11]:
> turned off unnecessary spew, should not be present at by default, let alone in 0.6.0
...
> --- gstobject.c	17 Jan 2003 20:02:26 -0000	1.55
> +++ gstobject.c	31 Jan 2003 06:07:27 -0000	1.55.4.1
> @@ -382,7 +382,8 @@
>        str = g_strdup_value_contents (&value);
>      }
>      name = gst_object_get_path_string (orig);
> -    g_print ("%s: %s = %s\n", name, pspec->name, str);
> +/* This should not be done as a default regardless. */
> +/*    g_print ("%s: %s = %s\n", name, pspec->name, str); */
>      g_free (name);
>      g_free (str);
>      g_value_unset (&value);
> 

The g_print is the whole point of this default handler.  Why comment it
out?  Since this is an exported API function it should probably actually
function.  I assume apps will adopt similar options that gst-launch has
(--silent and --exclude) if they use this handler so there seems to be
no reason to nullify it.  If you think it's a bad default for gst-launch
then maybe gst-launch should be changed to have a --verbose option
instead of --silent.

(This has been in the code for months... why are you changing the
functionality right before release?  I actually thought it was a nice
debugging tool.)

-dave