[gst-devel] Re: [gst-cvs] company gst-plugins: gst-plugins/gst/mpegstream/

Ronald Bultje R.S.Bultje at pharm.uu.nl
Thu May 22 04:16:03 CEST 2003

Hey Benjamin,

At 03:42 AM 5/22/03 -0700, you wrote:
>case ranges is a gcc extension, removing them
>+      } else if (stream_id >= 0xE0 && stream_id < 0xF0) {
>-	case 0xE0 ... 0xEF:

This is... Hideous! Stop this, please. if/else things are
meant for one- or two-order comparisons, not for full lists.
Use multiple case statements instead:

case 0xE0: case 0xE1:
case 0xEE: case 0xEF:

That might be a few more lines of code, but it'll actually
look good. multi-order if/else stuff looks *horrible*, imho.


More information about the gstreamer-devel mailing list