[gst-devel] Re: [Ffmpeg-devel] ffmpeg patch for Solaris

[Falk Hueffner]

Brian Cameron <Brian.Cameron at sun.com> writes:

> +#        ifdef DEBUG
> +#            define dprintf(...) printf(__VA_ARGS__)
> +#        else
> +#            define dprintf(...)
> +#        endif
> +
> +#endif

Let's use the this variant unconditionally, gcc supports it since at
least 2.95.

> +#ifdef DEBUG
>      dprintf("frame %d:\n", s->frame_count);
> +#endif
> +

I don't see the point here.

> +#ifdef __SUNPRO_C
> +typedef struct {
> +#else
>  typedef struct __attribute__((packed)) {
> +#endif
>      GUID guid;			// generated by client computer
>      uint64_t file_size;		// in bytes

This is ugly. I suggest to add a macro ATTRIBUTE_PACKED, check for it
in configure, and add some sanity checks like

extern char dummy[sizeof (struct foo) == 16 ? 1 : -1]

> -    { CODEC_ID_MPEG4, MKTAG('m', 'p', '4', 's'), .invalid_asf = 1 },
> +    { CODEC_ID_MPEG4, MKTAG('D', 'I', 'V', 'X'), 1 },

Does the Sun compiler really not support this 4 years after the
standard is finished?

-- 
	Falk