[gst-devel] Re: thomasvs gstreamer: gstreamer/ gstreamer/gst/

[Benjamin Otte]

Disabling something because it doesn't work and you don't know how to fix
it is not ok, especially not if you just do it without asking the people
who did this first.
The correct solution would have been to file a bug about this or fix it
correctly of course.

And for the record: I consider a working test much more important than a
distcheck that leaves files somewhere.

Benjamin


Thomas Vander Stichele <thomasvs <at> pdx.freedesktop.org> writes:

>
> CVS Root:       /cvs/gstreamer
> Module:         gstreamer
> Changes by:     thomasvs
> Date:           Mon Apr 05 2004  06:34:45 PDT
>
> Log message:
> adding Ronald's timestamp debug defines
>
> Modified files:
>     .               : ChangeLog
>     gst             : gstinfo.h
>
> Links:
>
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.396&r2=1.397
>
http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstinfo.h.diff?r1=1.68&r2=1.69
>
> ====Begin Diffs====
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v
> retrieving revision 1.396
> retrieving revision 1.397
> diff -u -d -r1.396 -r1.397
> --- a/ChangeLog	5 Apr 2004 10:25:55 -0000	1.396
> +++ b/ChangeLog	5 Apr 2004 13:34:33 -0000	1.397
>  <at>  <at>  -1,5 +1,9  <at>  <at>
>  2004-04-05  Thomas Vander Stichele  <thomas at apestaart dot org>
>
> +	* gst/gstinfo.h: adding Ronald's timestamp debugging defines
> +
> +2004-04-05  Thomas Vander Stichele  <thomas at apestaart dot org>
>  	* testsuite/elements/Makefile.am:
>            disable test until it stops breaking make distcheck
> Index: gstinfo.h
> RCS file: /cvs/gstreamer/gstreamer/gst/gstinfo.h,v
> retrieving revision 1.68
> retrieving revision 1.69
> diff -u -d -r1.68 -r1.69
> --- a/gstinfo.h	3 Apr 2004 04:16:24 -0000	1.68
> +++ b/gstinfo.h	5 Apr 2004 13:34:33 -0000	1.69
>  <at>  <at>  -521,6 +521,14  <at>  <at>
>  void gst_debug_print_stack_trace (void);
> +/* timestamp debugging macros */
> +#define GST_TIME_FORMAT "%u:%02u:%02u:%09u"
> +#define GST_TIME_ARGS(t) \
> +	(guint) (t / (GST_SECOND * 60 * 60)), \
> +	(guint) ((t / (GST_SECOND * 60)) % 60), \
> +	(guint) ((t / GST_SECOND) % 60), \
> +	(guint) (t % GST_SECOND)
>  G_END_DECLS
>  #endif /* __GSTINFO_H__ */
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
>