[gst-devel] gnomevfssink

[Benjamin Otte]

On Sun, 4 Apr 2004, Ronald S. Bultje wrote:

> Hi,
>
> attached patch fixes gnomevfssink's signals, which appeared slightly
> broken (prototype being void func(GstElement *, GstPad *), signal
> definition being VOID__VOID and the signal emission being void
> func(GstElement *, gboolean erase);. It changes it to a boolean signal,
> to which the app could connect to pop-up a dialog asking to overwrite
> the file or not. It also removes some random useless cruft ('handoff'
> signal) and adds some other random cruft ('uri' property).
>
> OK to apply? Or might this break apps after all?
>
A broken property is of course a bug that needs to be fixed. I don't care
about handoff and would just remove it, but that's just me.

But I don't like the part that adds a property to check for signal
emission. You should just always emit the signal and handle it with the
accumulator.


Benjamin