[gst-devel] alignment issues
Ronald S. Bultje
R.S.Bultje at students.uu.nl
Wed Apr 7 17:27:47 CEST 2004
On Wed, 2004-04-07 at 23:08, Daniel Gazard wrote:
See attached patch... It's slightly simpler.
> - I put udpsink, serv_addr, serverhost, FILE *f, guint bc_val in the
> ifndef since there are not used when GST_DISABLE_LOADSAFE is defined.
> - I put « g_free (buf) » in the ifndef too because buf is not declared
> when GST_DISABLE_LOADSAFE is defined (which it yield a compilation
> - Without the patch, when GST_DISABLE_LOADSAVE is defined the switch
> statement in gst_tcpsink_sink_link is disabled but a few case (as the
> C keyword sense) subsist (CONTROL_NONE and default) which cause a
> build fail.
> - Disable ret, client_sock and caps since they are not used when
> GST_DISABLE_LOADSAVE is defined.
> - Put xmlDocPtr doc in the ifndef to disable the libxml dependency
> (which is, as far as I know, what GST_DISABLE_LOADSAFE should do).
> - Put « g_free (buf) » in the ifndef for the same reason as
> I'm absolutely not sure if it is the right way to fix these problems
> but it seems there are troubles with this files when
> GST_DISABLE_LOADSAFE is defined. May be you should compile gstreamer
> with GST_DISABLE_LOADSAFE set and then try to compile plugins to see
> exactly what's wrong.
This makes sense, so don't worry. But please put them in a separate
patch to make clear that it's not part of this one.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5331 bytes
Desc: not available
More information about the gstreamer-devel