[gst-devel] wavparse query

iain iain at prettypeople.org
Sat Apr 17 11:42:02 CEST 2004


In marlin when I was loading wavs it would hit an error at line 731 of
gstwavparse.c which is in this code block

if (got_bytes != desired) {
	/* EOS? */
        GstEvent *event;
        guint32 remaining;
                                                                                
        gst_bytestream_get_status (bs, &remaining, &event);
        if (event && GST_EVENT_TYPE (event) == GST_EVENT_EOS) {
        	gst_pad_event_default (wavparse->sinkpad, event);
        } else {
        	GST_ELEMENT_ERROR (element, RESOURCE, READ, (NULL), (NULL));
        }
        return;
}

Now, I'm not sure, but I suspect that the inner if statement is supposed
to only error if its not an event? I commented out the
&& GST_EVENT_TYPE (event) == GST_EVENT_EOS and it all worked fine.

Is that the correct fix, or am I confused?

iain





More information about the gstreamer-devel mailing list