[gst-devel] Re: [gst-cvs] company gst-plugins: gst-plugins/ gst-plugins/ext/mad/

[David Schleef]

On Thu, Feb 05, 2004 at 06:34:33PM +0100, in7y118 at public.uni-hamburg.de wrote:
> Quoting "Ronald S. Bultje" <rbultje at ronald.bitfreak.net>:
> 
> > Hi,
> > 
> > On Wed, 2004-02-04 at 23:17, Benjamin Otte wrote:
> > > -    return gst_pad_renegotiate (tag->srcpad) == GST_PAD_LINK_REFUSED;
> > > +    return gst_pad_renegotiate (tag->srcpad) != GST_PAD_LINK_REFUSED;
> > 
> > Shouldn't you use GST_PAD_LINK_FAILED()/SUCCESSFUL() macros? DELAYED is
> > "not ok" too, that's why these macro's exist...
> > 
> I think there was a reason for why I wanted to allow DELAYED. I'm not sure 
> what it was though.
> 
> IMHO it would be much nicer if those functions returned TRUE/FALSE anyway for 
> apps/plugins. Only the core needs to know about DELAYED and such.

Agreed.  I would have done this, but it seemed a bit too difficult
at the time, and would have created even more bugs.



dave...