[gst-devel] Re: [gst-cvs] ds gstreamer: gstreamer/ gstreamer/gst/elements/

David I. Lehn dlehn at vt.edu
Fri Feb 13 13:47:20 CET 2004


* David Schleef <ds at pdx.freedesktop.org> [2004-02-13T15:34:33-0500]:
> CVS Root:       /home/cvs/gstreamer
> Module:         gstreamer
> Changes by:     ds
> Date:           Fri Feb 13 2004  12:16:54 PST
... 
> Modified files:
>     .               : ChangeLog
>     gst/elements    : gstfdsrc.c gstfdsrc.h
...
> +  if (src->timeout != 0)
> +  {
> +    tp->tv_sec = src->timeout / 1000000000;
> +    tp->tv_usec = src->timeout - t.tv_sec * 1000000000;
> +  }
...
> +  guint64 timeout;  /* read timeout, in nanoseconds */

Maybe this code should use some utils from gstclock.h.  Like
GstClockTime instead of guint64 and GST_SECOND instead of typo-prone
constants.  Or better yet GST_TIME_TO_TIMEVAL(), though the conversion
code is slightly different here?

-dave




More information about the gstreamer-devel mailing list