[gst-devel] Re: [gst-cvs] dolphy gst-plugins: gst-plugins/ gst-plugins/sys/ximage/ gst-plugins/sys/xvimage/

[David Schleef]

On Mon, Jan 12, 2004 at 06:41:06AM -0800, Julien Moutte wrote:
> CVS Root:       /home/cvs/gstreamer
> Module:         gst-plugins
> Changes by:     dolphy
> Date:           Mon Jan 12 2004  06:41:05 PST
> 
> Log message:
> 2004-01-12  Julien MOUTTE <julien at moutte.net>
> 	* sys/ximage/ximagesink.c: (gst_ximagesink_chain):
> 	* sys/xvimage/xvimagesink.c: (gst_xvimagesink_chain): Fixing the
> 	direct put buffers detection. I prefer checking GST_BUFFER_PRIVATE
> 	than the free_func.

GST_BUFFER_PRIVATE(buffer) may be non-NULL for a variety of reasons,
including the buffer being a subbuffer, or having been allocated by
efence or v4lsrc.  So this change is wrong.



dave...