[gst-devel] Re: [gst-cvs] jsimon gst-plugins: gst-plugins/ gst-plugins/ext/ffmpeg/

[David I. Lehn]

* Jeremy Simon <jsimon at pdx.freedesktop.org> [2004-01-26T16:08:59-0500]:
> 2004-01-26  Jeremy Simon  <jesimon at libertysurf.fr>
>         * ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_caps_to_extradata):
>         Fix SVQ3 decoding on PPC
...
> Index: gstffmpegcodecmap.c
> ===================================================================
> RCS file: /home/cvs/gstreamer/gst-plugins/ext/ffmpeg/gstffmpegcodecmap.c,v
> retrieving revision 1.38
> retrieving revision 1.39
> diff -u -d -r1.38 -r1.39
> --- gstffmpegcodecmap.c	26 Jan 2004 20:01:36 -0000	1.38
> +++ gstffmpegcodecmap.c	26 Jan 2004 21:04:32 -0000	1.39
> @@ -703,6 +703,9 @@
>        flags |= thirdpel_flag;
>        flags = flags << 3;
>  
> +      if (G_BYTE_ORDER == G_BIG_ENDIAN)
> +	flags = (flags << 8) | (8 >> flags);
> +	
>        memcpy (context->extradata + 0x62, &flags, 2);
>        context->extradata_size = 0x64;
>      }

I assume this is a typo.  A fine example of why you should use the glib
byte swapping macros.

-dave