[gst-devel] indent stuff

Ronald S. Bultje R.S.Bultje at students.uu.nl
Sun Mar 14 15:40:00 CET 2004


Hi,

function declarations in header files are unreadable. Example:

GstBuffer *gst_buffer_span (GstBuffer * buf1, guint32 offset, GstBuffer * buf2,
    guint32 len);

I suggest we use -lp/--continue-at-parentheses for header files:

gboolean gst_element_implements_interface (GstElement * element,
                                           GType iface_type);

I actually want it for source files too, but Benjamin seems to disagree.
I don't care that much about yes or no using -lp in source files, but
consider it an absolute requirement for header files.

Comments?

There's also a bug in virtual function declarations in header file
structs. Example:

typedef struct _GstImplementsInterfaceClass
{
  GTypeInterface parent;
                                                                                
  /* virtual functions */
    gboolean (*supported) (GstImplementsInterface * iface, GType iface_type);
                                                                                
  gpointer _gst_reserved[GST_PADDING];
} GstImplementsInterfaceClass;

4 spaces instead of 2 indented. Anyone know how to fix that?

Ronald




More information about the gstreamer-devel mailing list