[gst-devel] Re: [gst-cvs] thomasvs gstreamer: gstreamer/ gstreamer/docs/libs/ gstreamer/docs/libs/tmpl/ gstreamer/libs/gst/ gstreamer/libs/gst/dataprotocol/

[Thomas Vander Stichele]

Hi,

> > /*** private functions ***/
> > #define GST_DP_WRITE_GUINT64(buf, value) (*((guint64 *) (buf)) = GUINT64_TO_BE (value))
> > #define GST_DP_WRITE_GUINT32(buf, value) (*((guint32 *) (buf)) = GUINT32_TO_BE (value))
> > #define GST_DP_WRITE_GUINT16(buf, value) (*((guint16 *) (buf)) = GUINT16_TO_BE (value))
> [..]
> > /* read the given type out of the byte buffer using glib conversion macros */
> > #define GST_DP_GUINT16(x)		GUINT16_FROM_BE (* (guint16 *) (x))
> > #define GST_DP_GUINT32(x)		GUINT32_FROM_BE (* (guint32 *) (x))
> > #define GST_DP_GUINT64(x)		GUINT64_FROM_BE (* (guint64 *) (x))
> 
> Please use the functions in utils.h instead. Those don't work on ARM and
> other platforms and they're duplicates anyway. :).

Yep, was going to do that after I checked the regression test would
still work with the change.  They do, so I commited those changes
yesterday as well.

Thomas


Dave/Dina : future TV today ! - http://www.davedina.org/
<-*- thomas (dot) apestaart (dot) org -*->
I'm so boring my clothes wanna keep
somebody else warm someone cooler
<-*- thomas (at) apestaart (dot) org -*->
URGent, best radio on the net - 24/7 ! - http://urgent.fm/