[gst-devel] Re: [gst-cvs] rbultje gst-ffmpeg: gst-ffmpeg/ gst-ffmpeg/ext/ffmpeg/

[David I. Lehn]

* Thomas Vander Stichele <thomas at apestaart.org> [2004-10-25T19:02:22-0400]:
> I'm sorry, but I have no idea what you two are talking about.  Can you
> be more specific about what is wrong ?
> 

The diffs are wrong.  See the missing break statements?  The actual diff
should have those.

-dave

> On Mon, 2004-10-25 at 00:47, David I. Lehn wrote:
> > * Ronald S. Bultje <rbultje at freedesktop.org> [2004-10-24T18:26:44-0400]:
> > > Index: gstffmpegcodecmap.c
> > > RCS file: /home/cvs/gstreamer/gst-ffmpeg/ext/ffmpeg/gstffmpegcodecmap.c,v
> > > retrieving revision 1.62
> > > retrieving revision 1.63
> > > diff -u -d -r1.62 -r1.63
> > > --- gstffmpegcodecmap.c	4 Oct 2004 16:11:30 -0000	1.62
> > > +++ gstffmpegcodecmap.c	24 Oct 2004 22:24:43 -0000	1.63
> > > @@ -1685,3 +1685,267 @@
> > >    return id;
> > >  }
> > > +G_CONST_RETURN gchar *
> > > +gst_ffmpeg_get_codecid_longname (enum CodecID codec_id)
> > > +{
> > > +  const gchar *name = NULL;
> > > +  switch (codec_id) {
> > > +    case CODEC_ID_MPEG1VIDEO:
> > > +      name = "MPEG-1 video";
> > > +      break;
> > > +    case CODEC_ID_MPEG2VIDEO:
> > > +      name = "MPEG-2 video";
> > > +    case CODEC_ID_H263:
> > > +      name = "H.263 video";
> > > +    case CODEC_ID_RV10: