[gst-devel] Bug in gst_bin_set_state ?

[Andreas Rottmann]

"Ronald S. Bultje" <rbultje at ronald.bitfreak.net> writes:

> Hi,
>
> On Thu, 2005-01-20 at 14:55, Andreas Rottmann wrote:
>> I tried to get v4l2src to work with gstreamer, and in the process
>> found out that gst_v4l2src_change_state was never called when setting
>> the state of the pipeline.
>
> That indicates a state-change failure (probably due to failing caps
> negotiation)... Did you check the return value? Dunno about the patch.
> ;). The else { .. } will call _change_state, which will call
> gst_bin_change_state(), which will call
> gst_bin_foreach(set_kid_state_func) on all kids per state instead of
> one-for-all, which is the correct behaviour if you ask me. I'm not
> totally convinced that the if { .. } is needed at all, but your patch
> doesn't seem right if you look at it that way.
>
OK, this has been sorted out on IRC. This wasn't a bug at all, it's
just me who was fooled into thinking it was one. 

Thanks Ronald, for getting me on track.

Rotty
-- 
Andreas Rottmann         | Rotty at ICQ      | 118634484 at ICQ | a.rottmann at gmx.at
http://yi.org/rotty      | GnuPG Key: http://yi.org/rotty/gpg.asc
Fingerprint              | DFB4 4EB4 78A4 5EEE 6219  F228 F92F CFC5 01FD 5B62

I have a truly elegant proof of the  above, but it is too long to
fit into this .signature file.