[gst-devel] Re: [gst-cvs] thomasvs gst-ffmpeg: gst-ffmpeg/ext/ffmpeg/

[Ronald S. Bultje]

On Sat, 2005-10-01 at 12:06 +0200, Thomas Vander Stichele wrote:
> On Fri, 2005-09-30 at 14:04 -0400, Ronald S. Bultje wrote:
> > On Fri, 2005-09-30 at 02:29 -0700, Thomas Vander Stichele wrote:
> > > Log message:
> > > replace do { } while (0); with { }
> > 
> > That causes issues with some old stupid compilers, IIRC. Stylishly, I
> > don't like it at all.
> 
> Me too.  Do you know which ? When I asked nobody could give me a
> definitive answer, and IIRC there are lots of places in the core where
> { } is used, so I'd prefer to have the same style anywhere.

Then just use G_STMT_START/END. I've seen this used in a lot of error
routines in core, and personally think it's pretty ugly... In most
cases, it's not even needed, because the only reason why you'd want this
is to have local-scope variable declarations or multi-function macros.

Ronald