[gst-devel] Re: [gst-cvs] zeenix gst-plugins-bad: gst-plugins-bad/ gst-plugins-bad/ext/gsm/

[burger at speedy.org]

On Wed, 26 Oct 2005 11:13:45 +0200
Andy Wingo <wingo at pobox.com> wrote:

Hey,

> Hi Zeeshan and Philippe,
> 
> A few questions about this one:
> 
> On Tue, 2005-10-25 at 09:12 -0700, Zeeshan Ali wrote:
> > Over-writing Wim's gsm plugins (currently not working) with that
from the farsight repo. Also made sure that they work with the RTP
(de)payloader.
> > --- gstgsm.c	23 Sep 2005 17:05:29 -0000	1.13
> > +++ gstgsm.c	25 Oct 2005 16:12:03 -0000	1.14
> > @@ -1,5 +1,7 @@
> > -/* GStreamer
> > - * Copyright (C) <1999> Erik Walthinsen <omega at cse.ogi.edu>
> > +/*
> > + * Farsight
> > + * GStreamer GSM encoder/decoder (uses WAV49 compiled libgsm)
> > + * Copyright (C) 2005 Philippe Khalaf <burger at speedy.org>
> 
> These files are clearly taken from gstreamer, modified, and then
> returned. Thus you should not remove copyright lines. Also now that
they
> are in GStreamer, they should say GStreamer at the top.
What makes you think they are clearly taken from gstreamer, modified and
then returned? It's a new file, the only thing that looks like other
gstreamer files is the basic gst element template? I mean I don't want
to make a fuss but I would like to understand. Does this mean that any
gstreamer element must have GStreamer at the top in the copyrights?

> 
> >  GST_PLUGIN_DEFINE (GST_VERSION_MAJOR,
> >      GST_VERSION_MINOR,
> >      "gsm",
> > -    "GSM Elements Plugin",
> > -    plugin_init, VERSION, "LGPL", GST_PACKAGE, GST_ORIGIN)
> > +    "GSM encoder/decoder",
> > +    plugin_init, VERSION, "LGPL", "Farsight",
"http://farsight.sf.net")
> 
> Likewise...

Same thing here.
> 
> >  GstElementDetails gst_gsmdec_details = {
> >    "GSM audio decoder",
> >    "Codec/Decoder/Audio",
> >    "Decodes GSM encoded audio",
> > -  "Wim Taymans <wim.taymans at chello.be>",
> > +  "Philippe Khalaf <burger at speedy.org>",
> 
> Normally we just add on names
And here...


Thanks,
Philippe Khalaf