[gst-devel] [gst-cvs] ensonic gstreamer: gstreamer/ gstreamer/libs/gst/base/

[Michael Smith]

On Thu, 2007-12-13 at 08:50 -0800, ensonic at kemper.freedesktop.org wrote:
> CVS Root:       /cvs/gstreamer
> Module:         gstreamer
> Changes by:     ensonic
> Date:           Thu Dec 13 2007  16:50:08 UTC
> 
> Log message:
> 	* libs/gst/base/gstbasesink.c:
> 	* libs/gst/base/gstbasesrc.c:
> 	* libs/gst/base/gstbasetransform.c:
> 	  Replace gst_pad_get_parent by GST_OBJECT_PARENT inside streaming
> 	  thread. Correct log message in gstbasesrc.c.

Why? 

This doesn't look right, at least without a much more complete
explanation.

gst_pad_get_parent() takes the object lock. You've replaced it with code
that does not take the object lock, and is not called with the object
lock taken.

Please explain or revert. I think reversion is needed.

Mike