[gst-devel] [gst-cvs] ensonic gst-plugins-good: gst-plugins-good/ gst-plugins-good/gst/wavparse/

[Tim Müller]

On Fri, 2007-03-02 at 13:29 +0000, Stefan Kost wrote:

> Module:         gst-plugins-good
> Changes by:     ensonic
> Date:           Fri Mar 02 2007  13:29:37 UTC
> 
> Log message:
> Patch by: René Stadler <mail at renestadler.de>
> * gst/wavparse/gstwavparse.c: (uint64_ceiling_scale_int),
> (gst_wavparse_perform_seek), (gst_wavparse_stream_headers),
> (gst_wavparse_stream_data):
> Handle rounding better to not drop last sample frame. Fixes #356692

...

> -    duration = gst_util_uint64_scale_int (wav->datasize, GST_SECOND, wav->bps);
> +    duration = uint64_ceiling_scale_int (wav->datasize, wav->bps, GST_SECOND);

...

> -    timestamp = gst_util_uint64_scale_int (pos, GST_SECOND, wav->bps);
> +    timestamp = uint64_ceiling_scale_int (pos, wav->bps, GST_SECOND);
> -    next_timestamp = gst_util_uint64_scale_int (nextpos, GST_SECOND, wav->bps);
> +    next_timestamp = uint64_ceiling_scale_int (nextpos, wav->bps, GST_SECOND);

Is there a reason for the swapping of numerator and denominator? It's
not in the original patch as far as I can see. Where did it come from?

 Cheers
  -Tim