[gst-devel] [gst-cvs] sebastien gst-plugins-good: gst-plugins-good/ gst-plugins-good/gst/level/ gst-plugins-good/gst/rtp/ gst-plugins-good/win32/vs6/

[David Schleef]

On Thu, May 10, 2007 at 02:20:21PM +0200, Stefan Kost wrote:
> hi,
> 
> david, what is your concern here exactly.

Exactly what I said -- it breaks the build.  GCC complains about
it.

> the process() function cast  
> it to the right type and in_data += (filter->width / 8); works in  
> bytes anyway.

Ah, this is the original reason for changing gpointer to guchar *.
I missed that.  *That* makes sense, so applying a patch that compiles
also makes sense.



dave...


> 
> Stefan
> 
> Quoting Sebastien Moutte <sebastien at moutte.net>:
> 
> > Yes, my bad I shouldn't change gpointer in DEFINE_INT_LEVEL_CALCULATOR
> > macro.
> >
> > But I can't build level on vs6 if I don't change gpointer in_data; in
> > gst_level_transform_ip.
> > I talked about that with Mike and ensonic some weeks ago on IRC and they
> > approved if I remember well.
> >
> > Regards,
> > Sebastien
> >
> > -----Original Message-----
> > From: gstreamer-devel-bounces at lists.sourceforge.net
> > [mailto:gstreamer-devel-bounces at lists.sourceforge.net] On Behalf Of David
> > Schleef
> > Sent: jeudi 10 mai 2007 03:27
> > To: gstreamer-devel at lists.sourceforge.net
> > Subject: Re: [gst-devel] [gst-cvs] sebastien gst-plugins-good:
> > gst-plugins-good/ gst-plugins-good/gst/level/ gst-plugins-good/gst/rtp/
> > gst-plugins-good/win32/vs6/
> >
> > On Wed, May 09, 2007 at 09:31:05PM +0000, Sebastien Moutte wrote:
> >> CVS Root:       /cvs/gstreamer
> >> Module:         gst-plugins-good
> >> Changes by:     sebastien
> >> Date:           Wed May 09 2007  21:31:05 UTC
> >>
> >> Log message:
> >> * gst/level/gstlevel.c: (gst_level_calculate_##TYPE),
> >> (gst_level_transform_ip):
> >> Use guint8 * instead of gpointer then vs6 know the size of data
> >> pointed when moving the pointer.
> >
> > I reverted this because it breaks the build.  The change doesn't make
> > any sense anyway.
> >
> >
> >
> > dave...
> >
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > gstreamer-devel mailing list
> > gstreamer-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
> >
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > gstreamer-devel mailing list
> > gstreamer-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
> >
> 
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel