[gst-devel] typefind cleanups

Stefan Kost ensonic at hora-obscura.de
Wed Oct 24 10:54:02 CEST 2007


hi,

I belive we need some stricter rules for the gsttypefindfunctions.c.
Currently typefindplugin works down the registered typefind funtions  
by ranks and alphabetical sort-order.
A quick analysis shows:
38 PRIMARY
46 SECONDARY
8 MARGINAL

Alphabetical sorting is done on feature name (e.g. "audio/x-au"). Thus  
we alsway first probe "application/", then "audio/", then "image/" and  
finally "video/".
Not really clever, but I have no better idea right now.

While looking at the primary ones I stbled over a few things:
* TYPE_FIND_REGISTER (plugin, "audio/iLBC-sh", GST_RANK_PRIMARY,
   shouldnt that be "audio/x-iLBC" ?
* not really widely used types as primary
   "audio/qcelp", "text/x-cmml"
   shouldn't they be secondary
* non container based type as primary
   "audio/x-flac",  "audio/x-vorbis", "video/x-theora", "video/x-dirac",
   "video/mpeg4", "audio/mpeg"
   shouldn't those be secondary too
* container based as secondary
   "video/x-ms-asf"
   shouldn't that be primary

Basically I would like to structure the  
gsttypefindfunctions.c::plugin_init() a bit so that we group them by  
rank (maybe even move move them into separate local function  
register_primary(), register_secondary(), ...)
Primary should be widly used container formats.
Secondary should be the non-so widly use container formats and codecs.
Marginal esoteric stuff

Any comments.

Stefan





More information about the gstreamer-devel mailing list