[gst-devel] [gst-cvs] ensonic gstreamer: gstreamer/ gstreamer/gst/

[Michael Smith]

On Thu, Aug 28, 2008 at 2:02 PM, Stefan Kost <ensonic at hora-obscura.de> wrote:
> hi,
>
> this 'fix' causes some trouble. The issue is basically that in
> gst/gstpadtemplate.c::465 we now make a copy and I unref the old caps, so that
> we don't leak it. This causes a problem for e.g. ffmpeg which e.g. in
> gstffmpegdemux.c:1652 keep a pointer to the caps, but never refs() it.

This is pretty clearly a bug in gstffmpeg (there are similar bugs in
alaw, at least, and possibly others). The documentation has always
been clear, that this function takes ownership of the caps.

However, obviously we don't want to just break everything suddenly.

I'd suggest: revert this change, fix all the plugins that rely on the
old behaviour, then after the next round of releases, reinstate the
fix, so we stop leaking caps.

Mike