[gst-devel] rfbsrc - support for shared desktop

[Benoit Fouet]

Hi,

Ilja Pavkovic wrote:
> Hi,
>> I wrote a patch to support shared desktops. Who can insert this change to
>> cvs?
>>     
> additionally to my original patch I also initialize shared_flag accordingly.  
> See attached file.
>   
> ------------------------------------------------------------------------
>
> diff -ruN gst-plugins-bad/gst/librfb.orig/gstrfbsrc.c gst-plugins-bad/gst/librfb/gstrfbsrc.c
> --- gst-plugins-bad/gst/librfb.orig/gstrfbsrc.c	2008-07-08 00:42:54.274796000 +0200
> +++ gst-plugins-bad/gst/librfb/gstrfbsrc.c	2008-07-08 10:21:34.323226828 +0200
> @@ -43,7 +43,8 @@
>    ARG_WIDTH,
>    ARG_HEIGHT,
>    ARG_INCREMENTAL,
> -  ARG_USE_COPYRECT
> +  ARG_USE_COPYRECT,
> +  ARG_SHARED
>  };
>  
>  GST_DEBUG_CATEGORY_STATIC (rfbsrc_debug);
> @@ -148,6 +149,9 @@
>    g_object_class_install_property (gobject_class, ARG_USE_COPYRECT,
>        g_param_spec_boolean ("use-copyrect", "Use copyrect encoding",
>            "Use copyrect encoding", FALSE, G_PARAM_READWRITE));
> +  g_object_class_install_property (gobject_class, ARG_SHARED,
> +      g_param_spec_boolean ("shared", "Share desktop with other clients",
> +          "Share desktop with other clients", TRUE, G_PARAM_READWRITE));
>   

you define it as read write...

>    gstbasesrc_class->start = GST_DEBUG_FUNCPTR (gst_rfb_src_start);
>    gstbasesrc_class->stop = GST_DEBUG_FUNCPTR (gst_rfb_src_stop);
>    gstbasesrc_class->event = GST_DEBUG_FUNCPTR (gst_rfb_src_event);
> @@ -273,6 +277,9 @@
>      case ARG_USE_COPYRECT:
>        src->decoder->use_copyrect = g_value_get_boolean (value);
>        break;
> +    case ARG_SHARED:
> +      src->decoder->shared_flag = g_value_get_boolean (value);
> +      break;
>      default:
>        break;
>   

... but you seem to lack the read part

-- 
Benoit Fouet
Purple Labs S.A.
www.purplelabs.com