[gst-devel] [gst-cvs] tvermeir gstreamer: gstreamer/ gstreamer/plugins/elements/

[Wim Taymans]

On Tue, 2008-06-24 at 15:38 +0200, Thijs Vermeir wrote:
> Hi,
> 
> On Tue, Jun 24, 2008 at 4:21 AM, Jan Schmidt <thaytan at noraisin.net> wrote:
> > Hiya,
> >
> > The commit below breaks multiqueue for me, and the unit test doesn't
> > pass any more.
> 
> All unit tests passes for me (linux 32-bit). Can you provide more
> information on what failles?

Something is racy:

wim at metal:~/gst/head/gstreamer/tests/check$ make
elements/multiqueue.forever
Running suite(s): multiqueue
80%: Checks: 5, Failures: 0, Errors: 1
elements/multiqueue.c:314:E:general:test_output_order:0: (after this
point) Test timeout expired

Wim

> 
> > Further, afaik the extra-size-buffers property is deliberately
> > non-functional - it used to be implemented, and then was removed in
> > favour of just incrementally growing the queues up to the max-size. The
> > properties themselves were left as empty stubs to prevent breaking API.
> > The deprecation obviously needs to be documented better.
> 
> Didn't know it was deprecated, I thought it was just not implemented.
> 
> > I think the change should be reverted. Is there a specific problem it
> > solved for you?
> 
> No, I implemented it because I couldn't match the current behavior
> with the documentation
> what it should do.
> 
> So if you prefer you can revert it, but however I'm interested in what
> is going wrong?
> 
> Gr,
> Thijs
> 
> >
> > J.
> >
> > On Sun, 2008-06-22 at 12:19 -0700, tvermeir at kemper.freedesktop.org
> > wrote:
> >> CVS Root:       /cvs/gstreamer
> >> Module:         gstreamer
> >> Changes by:     tvermeir
> >> Date:           Sun Jun 22 2008  19:19:50 UTC
> >>
> >> Log message:
> >>       * plugins/elements/gstmultiqueue.c:
> >>       Add functionality to extra-size-buffers property.
> >>
> >> Modified files:
> >>     .               : ChangeLog
> >>     plugins/elements: gstmultiqueue.c
> >>
> >> Links:
> >> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3934&r2=1.3935
> >> http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/plugins/elements/gstmultiqueue.c.diff?r1=1.33&r2=1.34
> >>
> >> -------------------------------------------------------------------------
> >> Check out the new SourceForge.net Marketplace.
> >> It's the best place to buy or sell services for
> >> just about anything Open Source.
> >> http://sourceforge.net/services/buy/index.php
> >> _______________________________________________
> >> gstreamer-cvs mailing list
> >> gstreamer-cvs at lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
> >>
> > --
> > Jan Schmidt <thaytan at noraisin.net>
> >
> >
> 
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel