[gst-devel] Felipe Contreras : util: Fix for allocate buffer.

[Jan Schmidt]

I like it. I'd prefer to see multiple commits-in-one-push bundled
together like we have had them - it encourages smaller, more atomic
commits. I'd prefer the "If for some reason a push contains too many
commits instead of sending
hundreds of e-mails it can send one big e-mail with a short
description of all the commits." one big e-mail option, with the
threshold set pretty low.

Jan.

On Wed, 2009-02-04 at 23:08 +0200, felipe.contreras at gmail.com wrote:
> Module: gst-openmax
> Branch: master
> Commit: 10c238e8a34c4693a742f596faec4efe2185ea77
> URL:    http://cgit.freedesktop.org/gstreamer/gst-openmax/commit/?id=10c238e8a34c4693a742f596faec4efe2185ea77
> 
> Author: Felipe Contreras <felipe.contreras at nokia.com>
> Date:   Wed Dec 10 18:58:03 2008 +0200
> 
> util: Fix for allocate buffer.
> 
> The buffer shall be freed only when allocated by us as opposed to some
> other element.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras at nokia.com>
> 
> ---
> 
>  omx/gstomx_util.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/omx/gstomx_util.c b/omx/gstomx_util.c
> index 429d47a..1b34b9b 100644
> --- a/omx/gstomx_util.c
> +++ b/omx/gstomx_util.c
> @@ -505,10 +505,11 @@ port_free_buffers (GOmxPort *port)
>  
>          if (omx_buffer)
>          {
> -#ifdef USE_ALLOCATE_BUFFER
> +#if 0
> +            /** @todo how shall we free that buffer? */
>              g_free (omx_buffer->pBuffer);
>              omx_buffer->pBuffer = NULL;
> -#endif /* USE_ALLOCATE_BUFFER */
> +#endif
>  
>              OMX_FreeBuffer (port->core->omx_handle, port->port_index, omx_buffer);
>              port->buffers[i] = NULL;
> 
> 
> 
> ------------------------------------------------------------------------------
> Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
> software. With Adobe AIR, Ajax developers can use existing skills and code to
> build responsive, highly engaging applications that combine the power of local
> resources and data with the reach of the web. Download the Adobe AIR SDK and
> Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
> 
-- 
Jan Schmidt <thaytan at noraisin.net>