[gst-devel] gstreamer: Wim Taymans : Add message to request a state change

[Felipe Contreras]

On Thu, Feb 19, 2009 at 11:47 AM, Edward Hervey <bilboed at gmail.com> wrote:
> Hi,
>
>  This looks really neat. A few comments though.
>
>  If the commit is not done to the master branch, is it possible to have
> that in the subject ? Something like the following:
>  "<module> [<branchname>]: <author> : <subject>"

Sure:

             push @notice, "Diff:   $gitweb_url/diff/?id=$obj" if $gitweb_url;
         }

-        if ($ref eq "master")
-        {
-            $subject = $repos_name . ": " . $info{"author_name"} . ":
" . ${$info{"log"}}[0];
-        }
-        else
-        {
-            $subject = $repos_name . ": " . $ref . ": " .
$info{"author_name"} . ": " . ${$info{"log"}}[0];
-        }
+        $subject = $repos_name . ": " . $info{"author_name"} . ": " .
${$info{"log"}}[0];
     }

     mail_notification($commitlist_address, $subject, "text/plain;
charset=UTF-8", @notice);

>  What happens for gigantic push with plenty of commits ? I did one a
> day or two ago in gst-plugins-bad.

I noticed that push :)

As I explained earlier, if there's more than 100 commits in a push
there will be a single email with the summary of the commits. The
number can be configured with $max_individual_notices.

>  It might be better to have a message-only (i.e. everything down to
> '---') version for the current commit list, and use the ones with
> patches on another mailing list. In fact... I'm wondering if we
> shouldn't create new mailing lists now that we've switched to git, I can
> have them created within the day on freedesktop.org. Something like
> gst-commits at ... and gst-commits-full at ...

Maybe... this script will not always return the whole diff, only when
it's less than 10000 bytes, and again, the number can be configured
with $max_diff_size.

Keep in mind that the email has the url to cgit, which contains the diff also.

Therefore I think the only valid reason the ml with the actuall diff
make sense is if somebody wants to make comments to some particular
lines, but I think a manual diff would server the purpose. The only
reason would be to avoid one click to the cgit url, but I don't think
that's a valid one.


BTW, I noticed there's an extra space after the author name, so I'm
attaching a new one (try 4) with a fix for that and your suggestion.

Cheers.

-- 
Felipe Contreras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: post-receive
Type: application/octet-stream
Size: 7463 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20090219/29786e9f/attachment.obj>