[gst-devel] gstrtpdec - memory leak

[Wim Taymans]

On Thu, 2009-06-25 at 13:04 +0200, Krzysztof Błaszkowski wrote:
> Hi folks,
> 
> Haven't i told already there is a memory leak ?
> 
> damn, what's wrong with you ?

Messages on this list are lossy. The correct place to put bugs and
patches (such as yours) is in bugzilla.

I've commited your patch in git now but please use bugzilla in the
future if you care about it not getting lost.

Wim

> 
> shall the gst_rtp_dec_chain_rtcp() dereference buffer in bad_packet path or if 
> there is no HAVE_RTCP ?
> 
> i do have such video server which doesn't stream audio but every couple 
> seconds it sends 48 bytes to udpsrc for audio. then these are collected by 
> gst_base_src_get_range() every time with new buffer.
> 
> if the gst_rtp_dec_chain_rtcp() misses gst_buffer_unref() here is the patch 
> included and now it works as expected.
> 
> seems that plugins-good-10.15 miss that patch too. there may be more places 
> which require buffer dereferencing but review code by yourself.
> 
> i'm going to unsubscribe from this list.
> 
> regards,
> Krzysztof Blaszkowski
> ------------------------------------------------------------------------------
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel