[gst-devel] bug in gstmpegdemux.c?

[pulq.ustc]

Hi Thiago,
It is from mpegdemux2 on -bad (
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/mpegdemux/gstmpegdemux.c
)

I filed a bug https://bugzilla.gnome.org/show_bug.cgi?id=606371 about this
issue. a patch is also attached in bug description.

Thanks!

On Fri, Jan 8, 2010 at 4:16 AM, thiagossantos at gmail.com <
thiagossantos at gmail.com> wrote:

>
>
> On Thu, Jan 7, 2010 at 6:47 AM, pulq.ustc <pulq.ustc at gmail.com> wrote:
>
>> Hi folks,
>>
>> Below is code snippet from gstmpegdemux.c:
>> ...
>> scr1 = GUINT32_FROM_BE (*(guint32 *) data);
>> scr2 = GUINT32_FROM_BE (*(guint32 *) (data + 4));
>> ...
>>
>> It doesn't work on ARM CPU due to the int*'s alignment.
>> Could we just change above code to use GST_READ_UINT32_BE(data)  instead?
>>
>
> Is this from mpegstream on -ugly?
>
> I couldn't find this piece of code. Could you check on git version and give
> us the line number or a patch?
>
> Also, bugzilla.gnome.org is the recommended place for requesting bugfixes
> and features.
>
> Thanks.
>
>
>>
>> Thanks!
>> --
>> ()   ASCII Ribbon Campaign
>> /\   Keep it simple!
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Verizon Developer Community
>> Take advantage of Verizon's best-in-class app development support
>> A streamlined, 14 day to market process makes app distribution fast and
>> easy
>> Join now and get one step closer to millions of Verizon customers
>> http://p.sf.net/sfu/verizon-dev2dev
>> _______________________________________________
>> gstreamer-devel mailing list
>> gstreamer-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>>
>>
>
>
> --
> Thiago Sousa Santos
>
>
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and
> easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
>
>


-- 
()   ASCII Ribbon Campaign
/\   Keep it simple!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20100108/c86b3b05/attachment.htm>