[gst-devel] [PATCH] gst-plugins-good: add a TV-norm selection parameter to v4l2sink

[Guennadi Liakhovetski]

On Wed, 10 Mar 2010, Clark, Rob wrote:

> I agree that an enum would be a good idea (have a look at "flags" 
> property.. search for GST_TYPE_V4L2_DEVICE_FLAGS in gstv4l2object.c for 
> an example)

ok, done that, but

> also.. I think it might be a good idea to put this property in 
> gstv4l2object.c (see the install/get/set_property_helper functions)..  
> so that both v4l2sink and v4l2src get the property.

there we get a conflict with the norm API for the tuner (see 
gst-plugins-base/gst-libs/gst/interfaces/tuner.c, etc.) gstv4l2object.c 
already contains some references to the tuner API, e.g., struct 
_GstV4l2Object already containse a

  gchar *norm;

pointer under "properties", and indeed there is a PROP_NORM property in 
gst_v4l2_object_set_property_helper(), but it is commented out... I tried 
to find out who committed that code, but it goes back to 
sys/v4l2/gstv4l2element.c from the original CVS... So, what do we do? 
Delete dead code and start anew?...

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/