[gst-devel] GstBaseSink - getcaps

[Tim-Philipp Müller]

On Wed, 2010-09-01 at 12:34 +0200, Julien Isorce wrote:

> If my X11 settings are 32 bpp then an annoying thing is that running
> "gst-launch-0.10 videotestsrc ! "video/x-raw-rgb, bpp=16, depth=16" !
> ximagesink" gives me an error from videotestsrc but I think the error
> should come from ximagesink.
>
> In ximagesink::gst_ximagesink_getcaps, the xcontext->caps is setup to
> bpp=32 and depth=24, so I think at this point it should check that
> this is not compatible with the required caps from my capfilter.
>
> The error is:
> "videotestsrc0 : Could not negotiate format" 
> and I think it should be:
> "ximagesink0 : Could not negotiate format"
>
> Any comment ?

Well, yes. We should find a way to report errors like this better, no
doubt. Currently there's no way to communicate error state to the
upstream element that drives the pipeline and eventually errors out
though, it just knows the flow return and that's that. I think there's a
bug about this somewhere in bugzilla, but can't find it right now. Feel
free to file a new one.

Cheers
 -Tim