gst-plugins-good: Revert "Pulsesink: Allow chunks up to bufsize instead of segsize"

[René Stadler]

On Fri, Apr 8, 2011 at 3:35 PM, Sebastian Dröge <
slomo at kemper.freedesktop.org> wrote:

> Module: gst-plugins-good
> Branch: master
> Commit: 11bcac7c9015c4db85514e7837cbd2d0f47b9ff1
> URL:
> http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=11bcac7c9015c4db85514e7837cbd2d0f47b9ff1
>
> Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
> Date:   Fri Apr  8 14:35:04 2011 +0200
>
> Revert "Pulsesink: Allow chunks up to bufsize instead of segsize"
>
> This reverts commit 1e2c1467ae042a3c6bb1a6bc0c07aeff13ec5edb.
>
> The commit causes pulsesink to ignore the latency-time baseaudiosink
> property.
>
[...]

Hi,

can you elaborate a bit on this? Strictly speaking, it's not true that the
property is ignored without the revert, since segsize/latency-time is still
passed to PA's minreq attribute. Since that is the minimum amount of free
space that must be available before pulse calls us for more data, that
should still have a huge effect (if not, there is something else wrong in
pulsesink).

I haven't measured the wakeup behavior and power consumption of pulsesink in
a while, so I'm wondering if you have some up-to-date empirical data that
prompted you to this revert :)

Regards,
--René
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20110408/5c785dec/attachment.htm>