gst-plugins-base-0.10.32: GST_DISABLE_XML=1 doesn't work in gstsubparse.c

[Tim-Philipp Müller]

On Tue, 2011-08-16 at 17:42 +0800, bcxa sz wrote:

Hi,

> I have cross compiled gstreamer on embedded system. And I have below
> flags in gst-plugins-base-0.10.32/gst/subparse/Makefile:

Maybe you should try the latest release, which is 0.10.35.

> GST_DISABLE_ALLOC_TRACE = 1
> GST_DISABLE_GST_DEBUG = 1
> GST_DISABLE_LOADSAVE = 1
> GST_DISABLE_PARSE = 1
> GST_DISABLE_PLUGIN = 1
> GST_DISABLE_REGISTRY = 1
> GST_DISABLE_TRACE = 1
> GST_DISABLE_XML = 1

You are setting Makefile variables here. These have nothing to do with
#ifdef and #ifndef.

> And look at the gstsubparse.c:
> #ifndef GST_DISABLE_XML
>     case GST_SUB_PARSE_FORMAT_SAMI:    	
>       self->parse_line = parse_sami;
>       sami_context_init (&self->state);
>       return gst_caps_new_simple ("text/x-pango-markup", NULL);
> #endif
> 
> This piece of code is assumed not to get compiled. But this is not
> true and it still get compiled.
> 
> And it seemed that GST_DISABLE_XML flag is not given to compiler with -D.

Those defines would usually be in config.h in the top-level directory
(created and set by configure dependent on whether libxml2 development
files + headers have been found or not).

Cheers 
 -Tim