gst-plugins-bad: aacparse: allow parsed frames on sink pad

[Stefan Kost]

Am 26.02.2011 15:43, schrieb Tim-Philipp Müller:
> On Fri, 2011-02-25 at 20:02 -0800, David Schleef wrote:
> 
>> Module: gst-plugins-bad
>> Branch: master
>> Commit: e49b89d5c5a1244fa0dcb8bb4996e38fb9bff9e5
>> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=e49b89d5c5a1244fa0dcb8bb4996e38fb9bff9e5
>>
>> Author: David Schleef <ds at schleef.org>
>> Date:   Wed Feb 23 17:25:03 2011 -0800
>>
>> aacparse: allow parsed frames on sink pad
> 
> Unfortunately we can't do that (yet) for parsers with a rank > NONE,
> because it might lead to decodebin/decodebin2 autoplugging the same
> parser over and over again in some cases..

I did that mistake once localy and I was wondering if we should extend the logic
in decodebin to not replug an element in the same group?

Stefan

> 
>  -Tim
> 
> 
>> ---
>>
>>  gst/audioparsers/gstaacparse.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/gst/audioparsers/gstaacparse.c b/gst/audioparsers/gstaacparse.c
>> index 09e3e71..fbdc165 100644
>> --- a/gst/audioparsers/gstaacparse.c
>> +++ b/gst/audioparsers/gstaacparse.c
>> @@ -58,7 +58,7 @@ static GstStaticPadTemplate sink_template = GST_STATIC_PAD_TEMPLATE ("sink",
>>      GST_PAD_SINK,
>>      GST_PAD_ALWAYS,
>>      GST_STATIC_CAPS ("audio/mpeg, "
>> -        "framed = (boolean) false, " "mpegversion = (int) { 2, 4 };"));
>> +        "framed = (boolean) { true, false}, " "mpegversion = (int) { 2, 4 };"));
> 
> 
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel