gst-plugins-bad: dvdspu: Fix pad templates

[Sebastian Dröge]

On Sun, 2011-05-29 at 23:05 +0200, Edward Hervey wrote:
> On Sun, 2011-05-29 at 19:02 +0100, Tim-Philipp Müller wrote:
> > On Sun, 2011-05-29 at 09:18 -0700, Edward Hervey wrote:
> > 
> > Hi,
> > 
> > > Module: gst-plugins-bad
> > > Branch: master
> > > Commit: 732828e31cbace59e6ce4f262b8339e43ed0c631
> > > URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=732828e31cbace59e6ce4f262b8339e43ed0c631
> > > 
> > > Author: Edward Hervey <bilboed at bilboed.com>
> > > Date:   Sun May 29 18:16:49 2011 +0200
> > > 
> > > dvdspu: Fix pad templates
> > > 
> > > Our caps intersection code is a bit too touchy about what an element
> > > returns compared to its pad templates.
> > 
> > What was the exact problem here? The change doesn't look like it should
> > be necessary at first glance: additional optional fields in the actual
> > caps shouldn't be a problem, and neither should the single-value list.
> > 
> > I think there may have been a regression with caps subset/intersection
> > handling in git core. I've seen a few other weird issues and
> > not-negotiated errors lately (but haven't investigated yet).
> 
>   I thought it was an issue noone had seen before and was specific to
> that element.
> 
>   It does fail indeed with other caps:
> 
>   c1 = gst.Caps("blah,something={1}")
>   c2 = gst.Caps("blah,something=2")
> 
>   c1.is_subset(c2) => FALSE
>   c2.is_subset(c1) => FALSE
>   c1.intersect(c2) => empty caps
>   
> 
>    This commit can be reverted once core is fixed.

That's probably my fault then and I'll try to fix it after understanding
what exactly is wrong.

In the example you give above, why do you think this is wrong though?
These two caps are completely distinct, none is a subset of the other
and the intersection should be empty because both are incompatible. What
am I missing? :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20110530/e9fe045a/attachment.pgp>