gst-plugins-base: oggdemux: remove avoidable call to gst_object_set_name

René Stadler mail at renestadler.de
Wed Oct 26 03:20:04 PDT 2011


On Wed, Oct 26, 2011 at 11:28 AM, Stefan Sauer <ensonic at hora-obscura.de> [...]
> -  ret = g_object_new (GST_TYPE_OGG_PAD, NULL);
> +  name = g_strdup_printf ("serial_%08x", serialno);
> +  ret = g_object_new (GST_TYPE_OGG_PAD, "name", name, NULL);
> +  g_free (name);
>
> what about gchar name[sizeof("serial_")+8] while you are on it

Yeah good point. I have seen these in multiple places, sometimes one
way and sometimes the other. I guess the g_snprintf method is
preferable everywhere.

--René


More information about the gstreamer-devel mailing list